Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline ContextHandler.MAX_FORM_CONTENT_SIZE_KEY #610

Merged
merged 1 commit into from
May 9, 2024
Merged

Inline ContextHandler.MAX_FORM_CONTENT_SIZE_KEY #610

merged 1 commit into from
May 9, 2024

Conversation

basil
Copy link
Member

@basil basil commented May 8, 2024

Jetty 10:

jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
145:    public static final String MAX_FORM_CONTENT_SIZE_KEY = "org.eclipse.jetty.server.Request.maxFormContentSize";

Jetty 12:

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/FormFields.java
42:    public static final String MAX_LENGTH_ATTRIBUTE = "org.eclipse.jetty.server.Request.maxFormContentSize";

As you can see, the string is the same, but now lives in FormFields.MAX_LENGTH_ATTRIBUTE rather than ContextHandler.MAX_FORM_CONTENT_SIZE_KEY.

To prepare ourselves for the transition, simplest just to inline the string so that we aren't depending on any particular calling convention.

Testing done

mvn clean install

@basil basil added the chore label May 8, 2024
@basil basil merged commit 5b274b2 into jenkinsci:master May 9, 2024
6 checks passed
@basil basil deleted the maxFormContentSize branch May 9, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@basil